[WIP] ENH: add option to delete a drive #550
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntolley
reviewed
Aug 25, 2022
| def clear_connectivity(self): | ||
| """Remove all connections defined in Network.connectivity | ||
| """ | ||
| def _clear_connectivity(self, src_types=None): |
There was a problem hiding this comment.
Actually I wonder if we should just combine this with the pick_connection API? Then you could flexibly specify which ones to delete
There was a problem hiding this comment.
Possibly, but for now I made it private so I don't need to answer that question ;-)
There was a problem hiding this comment.
You have two options: expose all the arguments that are in pick_connection. But this needs to be done in a consistent way. The other is to allow passing keyword arguments but then the documentation is not so nice because user will have to go to pick_connection function to check the documentation of clear_connectivity. But for now it's private ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.